apourchet commented on code in PR #16024:
URL: https://github.com/apache/kafka/pull/16024#discussion_r1608924234


##########
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java:
##########
@@ -0,0 +1,45 @@
+package org.apache.kafka.streams.processor.assignment;
+
+import java.util.Optional;
+import java.util.Set;
+
+/**
+ * This is a simple container class used during the assignment process to 
distinguish
+ * TopicPartitions type. Since the assignment logic can depend on the type of 
topic we're
+ * looking at, and the rack information of the partition, this container class 
should have
+ * everything necessary to make informed task assignment decisions.
+ */
+public interface TopicPartitionAssignmentInfo {

Review Comment:
   To elaborate on what I said I believe that generally speaking interfaces 
that are too broad when created get super bloated over time, so I usually err 
on the side of small and precise and expand if necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to