nicktelford commented on PR #16041: URL: https://github.com/apache/kafka/pull/16041#issuecomment-2126919697
@mjsax This is the final PR to add the KIP-989 metrics. Although I'm considering opening two, much smaller PRs: 1. To add some additional tests to ensure we cover all the Iterator constructors 2. To eliminate some redundancy now all the metrics have landed. Notably, we can replace the `AtomicInteger` used by `num-open-iterators` with just counting the cardinality of the `Set<MeteredIterator>` that we maintain for `oldest-iterator-open-since-ms`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
