jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612314113
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -156,16 +200,27 @@ object StorageTool extends Logging {
def getMetadataVersion(
namespace: Namespace,
+ featureNamesAndLevelsMap: Map[String, java.lang.Short],
defaultVersionString: Option[String]
): MetadataVersion = {
val defaultValue = defaultVersionString match {
case Some(versionString) =>
MetadataVersion.fromVersionString(versionString)
case None => MetadataVersion.LATEST_PRODUCTION
}
- Option(namespace.getString("release_version"))
- .map(ver => MetadataVersion.fromVersionString(ver))
- .getOrElse(defaultValue)
+ val releaseVersionTag = Option(namespace.getString("release_version"))
+ val featureTag = featureNamesAndLevelsMap.get(MetadataVersion.FEATURE_NAME)
+
+ (releaseVersionTag, featureTag) match {
+ case (Some(_), Some(_)) =>
+ throw new IllegalArgumentException("Both --release_version and
--feature were set. Only one of the two flags can be set.")
Review Comment:
Right. I can update this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
