gharris1727 commented on code in PR #16051:
URL: https://github.com/apache/kafka/pull/16051#discussion_r1612358604


##########
Jenkinsfile:
##########
@@ -36,6 +36,12 @@ def doTest(env, target = "test") {
   junit '**/build/test-results/**/TEST-*.xml'
 }
 
+def runTestOnDevBranch(env) {
+  if (!isChangeRequest(env)) {
+    doTest(env)
+  }
+}

Review Comment:
   I'm hesitant to sign up future release managers for additional verification 
of the 11 and 17 builds that the CI has been doing for previous releases. I 
don't expect any failures to be introduced that affect 11 and 17 but not 8 or 
21, but I would rather find those failures out in CI after merge than during 
the RC generation stage.
   
   And for selfish reasons, I also would like to continue seeing the 11 and 17 
trunk results published so I can do flaky test analysis. With this patch as-is, 
we're keeping the same number of test runs on trunk, but if we removed these 
entirely we would be cutting those in half. I don't pay attention to the PR 
builds for statistics because contributors may have bad patches applied that 
aren't worth investigating.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to