chia7712 commented on code in PR #16064:
URL: https://github.com/apache/kafka/pull/16064#discussion_r1612751256
##########
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##########
@@ -651,4 +651,17 @@ object DumpLogSegments {
def checkArgs(): Unit = CommandLineUtils.checkRequiredArgs(parser,
options, filesOpt)
}
+
+ private[tools] def newDecoder(className: String, props:
VerifiableProperties): Decoder[_] = {
+ val kclass =
Class.forName(className).getConstructor(props.getClass).newInstance(props)
Review Comment:
This way will require all implementations of new decoder have to offer a
constructor accepting properties. It seems to me that is not what we expected,
as the props is always empty. Also, we should use Reconfigurable interface for
consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
