FrankYang0529 commented on PR #15908: URL: https://github.com/apache/kafka/pull/15908#issuecomment-2131274897
> One high-level question: > I found after this change, we increased the test case numbers from 492 -> 660. And the time for this test suite takes form 1h 19m -> 1h 31m. Do we really need all these tests? Hi @showuon, thanks for the review and suggestion. Originally, old framework run 4 cases: * (ZK / KRAFT servers) with (group.coordinator.new.enable=false) with (classic group protocol) = 2 cases * (KRAFT server) with (group.coordinator.new.enable=true) with (classic group protocol) = 1 case * (KRAFT server) with (group.coordinator.new.enable=true) with (consumer group protocol) = 1 case In the new framework, we run 7 cases: * (ZK / KRAFT / CO_KRAFT servers) with (group.coordinator.new.enable=false) with (classic group protocol) = 3 cases * (KRAFT / CO_KRAFT servers) with (group.coordinator.new.enable=true) with (classic group protocol) = 2 cases * (KRAFT / CO_KRAFT servers) with (group.coordinator.new.enable=true) with (consumer group protocol) = 2 cases That is why testing time takes longer. In my latest update, I change to run following cases. Also, in old framework, we started KRAFT server with group.coordinator.new.enable=true twice. One for classic group protocol and another for consumer group protocol. In new framework, we can get supported group protocol by `ClusterInstance#supportedGroupProtocols`, so I use one KRAFT server with group.coordinator.new.enable=true to run two protocols. We can reduce time to setup one KRAFT cluster. I hope this change can reduce overall testing time. Thanks. * (ZK / KRAFT servers) with (group.coordinator.new.enable=false) with (classic group protocol) = 2 cases * (KRAFT servers) with (group.coordinator.new.enable=true) with (classic / consumer group protocols) = 2 cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
