lianetm commented on code in PR #16083: URL: https://github.com/apache/kafka/pull/16083#discussion_r1616082089
########## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java: ########## @@ -28,37 +28,37 @@ * This is applicable when the consumer is having Kafka auto-manage group membership. If the consumer directly assigns partitions, * those partitions will never be reassigned and this callback is not applicable. * <p> - * When Kafka is managing the group membership, a partition re-assignment will be triggered any time the members of the group change or the subscription + * When Kafka is managing the group membership, a partition re-assignment will be triggered whenever the members of the group change or the subscription * of the members changes. This can occur when processes die, new process instances are added or old instances come back to life after failure. - * Partition re-assignments can also be triggered by changes affecting the subscribed topics (e.g. when the number of partitions is + * Partition re-assignments can also be triggered by changing the subscribed topics (e.g. when the number of partitions is Review Comment: I guess it's about interpretation, but I actually find the original version much clearer. "changing the subscribed topics" seems a bit confusing, as its what we would use to refer to "changing the subscribed topic from T1 to T2", but here we want to refer to changes affecting the topics (ex. partition count changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
