[ 
https://issues.apache.org/jira/browse/KAFKA-7288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580819#comment-16580819
 ] 

ASF GitHub Bot commented on KAFKA-7288:
---------------------------------------

rajinisivaram closed pull request #5504: KAFKA-7288: Fix for 
SslSelectorTest.testCloseConnectionInClosingState
URL: https://github.com/apache/kafka/pull/5504
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 
b/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
index 3bb6244715e..cfd7fb3af8d 100644
--- a/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
+++ b/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
@@ -418,7 +418,9 @@ private KafkaChannel createConnectionWithStagedReceives(int 
maxStagedReceives) t
             selector.mute(id);
             for (int i = 0; i <= maxStagedReceives; i++) {
                 selector.send(createSend(id, String.valueOf(i)));
-                selector.poll(1000);
+                do {
+                    selector.poll(1000);
+                } while (selector.completedSends().isEmpty());
             }
 
             selector.unmute(id);


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Transient failure in SslSelectorTest.testCloseConnectionInClosingState
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-7288
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7288
>             Project: Kafka
>          Issue Type: Bug
>          Components: unit tests
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>            Priority: Major
>
> Noticed this failure in SslSelectorTest.testCloseConnectionInClosingState a 
> few times in unit tests in Jenkins:
> {quote}
> java.lang.AssertionError: Channel not expired expected null, but 
> was:<org.apache.kafka.common.network.KafkaChannel@4f> at 
> org.junit.Assert.fail(Assert.java:88) at 
> org.junit.Assert.failNotNull(Assert.java:755) at 
> org.junit.Assert.assertNull(Assert.java:737) at 
> org.apache.kafka.common.network.SelectorTest.testCloseConnectionInClosingState(SelectorTest.java:341)
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to