showuon commented on code in PR #16005: URL: https://github.com/apache/kafka/pull/16005#discussion_r1618107975
########## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ########## @@ -4034,6 +4034,7 @@ class ReplicaManagerTest { _ => Optional.of(mockLog), (TopicPartition, Long) => {}, brokerTopicStats) + remoteLogManager.startup() Review Comment: nit: indent is wrong. ########## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ########## @@ -1072,6 +1072,49 @@ class KRaftClusterTest { } } + @Test + def testCreateClusterAndCreateTopicWithRemoteLogManagerInstantiation(): Unit = { + val cluster = new KafkaClusterTestKit.Builder( + new TestKitNodes.Builder(). + setNumBrokerNodes(3). + setNumControllerNodes(3).build()) Review Comment: nit: 1 broker + 1 controller should be enough for this test scenario, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org