brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1618981478
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1090,14 +1094,15 @@ private void chainFuture(
}
@Override
- public String toString() {
- return "OffsetFetchRequestState{" +
- "requestedPartitions=" + requestedPartitions +
- ", memberId=" + memberInfo.memberId.orElse("undefined") +
- ", memberEpoch=" + (memberInfo.memberEpoch.isPresent() ?
memberInfo.memberEpoch.get() : "undefined") +
+ public String toStringBase() {
+ return super.toStringBase() +
+ ", memberInfo=" + memberInfo +
+ ", expirationTimeMs=" + (expirationTimeMs().isPresent() ?
expirationTimeMs() : "undefined") +
+ ", isExpired=" + isExpired +
+ ", requestedPartitions=" + requestedPartitions +
", future=" + future +
- ", " + toStringBase() +
- '}';
+ ", memberId=" + memberInfo.memberId.orElse("undefined") +
+ ", memberEpoch=" + (memberInfo.memberEpoch.isPresent() ?
memberInfo.memberEpoch : "undefined");
Review Comment:
Thank you for the suggestion, I added a toString() method to MemberInfo in
my latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
