ahuang98 commented on PR #16079: URL: https://github.com/apache/kafka/pull/16079#issuecomment-2137996953
This version updates the voter set from a new argument of updateLocalState. Ideally this would test that the voter set passed in is correct (i.e. we call `partitionState.lastVoterSet()` in the right places), but this would be more easily testable with KafkaRaftClientTest when the updateVoter RPC is in place. Tests are commented out because I wanted to check the new tests pass without rebasing the entire repo. And there are some in-flight changes to LeaderState that I'll need to rebase off of. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
