chia7712 commented on PR #16042:
URL: https://github.com/apache/kafka/pull/16042#issuecomment-2140664027
> The test names are testDescribeLogDirsWithoutAnyPartitionTopic and
testDescribeLogDirs.
It seems to me the method needs to come with the guarantee:
`DescribeLogDirsTopic` should not have empty `partitions`
Hence, could you please add following asserts to `testDescribeLogDirs`
```scala
responses.foreach { response =>
assertEquals(Errors.NONE.code, response.errorCode)
assertTrue(response.totalBytes > 0)
assertTrue(response.usableBytes >= 0)
assertFalse(response.topics().isEmpty)
response.topics().forEach(t => assertFalse(t.partitions().isEmpty))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
