chia7712 commented on code in PR #16133:
URL: https://github.com/apache/kafka/pull/16133#discussion_r1621350440
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -675,7 +677,7 @@ object DynamicLogConfig {
// Exclude message.format.version for now since we need to check that the
version
// is supported on all brokers in the cluster.
@nowarn("cat=deprecation")
- val ExcludedConfigs = Set(ServerLogConfigs.LOG_MESSAGE_FORMAT_VERSION_CONFIG)
Review Comment:
Do we need this variable? Maybe we can remove it by following change.
```scala
// Exclude message.format.version for now since we need to check that the
version
// is supported on all brokers in the cluster.
@nowarn("cat=deprecation")
val ReconfigurableConfigs =
ServerTopicConfigSynonyms.TOPIC_CONFIG_SYNONYMS.values.asScala.toSet -
ServerLogConfigs.LOG_MESSAGE_FORMAT_VERSION_CONFIG
```
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -319,7 +321,7 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
}
private def verifyReconfigurableConfigs(configNames: Set[String]): Unit =
CoreUtils.inWriteLock(lock) {
- val nonDynamic =
configNames.filter(DynamicConfig.Broker.nonDynamicProps.contains)
+ val nonDynamic = configNames.filter(nonDynamicProps.contains)
Review Comment:
How about `configNames.intersect(nonDynamicProps)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
