gharris1727 commented on code in PR #15513:
URL: https://github.com/apache/kafka/pull/15513#discussion_r1621400369


##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java:
##########
@@ -737,12 +739,12 @@ public void runOuterJoin(final StreamJoined<Integer, 
String, String> streamJoine
                 inputTopic1.pipeInput(expectedKey, "C" + expectedKey);
             }
             processor.checkAndClearProcessResult(
-                new KeyValueTimestamp<>(0, "C0+a0", 0L),
-                new KeyValueTimestamp<>(0, "C0+b0", 0L),
-                new KeyValueTimestamp<>(1, "C1+a1", 0L),
-                new KeyValueTimestamp<>(1, "C1+b1", 0L),
-                new KeyValueTimestamp<>(2, "C2+b2", 0L),
-                new KeyValueTimestamp<>(3, "C3+b3", 0L)
+                new KeyValueTimestamp<>(0, "C0+0", 0L),
+                new KeyValueTimestamp<>(0, "C0+0", 0L),
+                new KeyValueTimestamp<>(1, "C1+1", 0L),
+                new KeyValueTimestamp<>(1, "C1+1", 0L),

Review Comment:
   You're right, I didn't notice this. I did a search-and-replace renaming, and 
reverted the stuff which didn't make sense.
   
   I did have to manually renumber stuff like "a0-0", and some places where 
capital letters "A0" were used on the inputStream2 to fit the pattern better. 
PTAL, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to