pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1621488481
##########
core/src/main/scala/kafka/admin/AclCommand.scala:
##########
@@ -115,8 +115,6 @@ object AclCommand extends Logging {
val aclBindings = acls.map(acl => new AclBinding(resource,
acl)).asJavaCollection
adminClient.createAcls(aclBindings).all().get()
}
-
- listAcls(adminClient)
Review Comment:
- I've moved KRaft tests into a new `AclCommandIntegrationTest.java`
- Left old Zookeeper tests in `AclCommandTest.scala`. As I understand, we
are going to completely delete this test file, once fully moved to KRaft, am I
right? Do you think it's worth migrating those tests to java at this stage, if
they are going to be deleted anyway?
- Race condition described above, is still reproduced on a new
infrastructure :cry: So if there are no objections, we can probably remove
console output `Current ACLs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
