showuon commented on code in PR #16085: URL: https://github.com/apache/kafka/pull/16085#discussion_r1621524702
########## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ########## @@ -4251,6 +4251,22 @@ class UnifiedLogTest { assertEquals(new LogOffsetMetadata(14, -1L, -1), log.maybeConvertToOffsetMetadata(14)) } + @Test + def testGetFirstBatchTimestampForSegments(): Unit = { + val log = createLog(logDir, LogTestUtils.createLogConfig()) + + val segments: java.util.List[LogSegment] = new java.util.ArrayList[LogSegment]() + val seg1 = LogTestUtils.createSegment(1, logDir, 10, Time.SYSTEM) + val seg2 = LogTestUtils.createSegment(2, logDir, 10, Time.SYSTEM) Review Comment: Forgot to close them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org