ableegoldman commented on code in PR #15790:
URL: https://github.com/apache/kafka/pull/15790#discussion_r1621827532
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##########
@@ -58,8 +60,21 @@ public void addChild(final ProcessorNode<Void, Void, ?, ?>
child) {
public void init(final InternalProcessorContext<Void, Void> context) {
super.init(context);
this.context = context;
- keySerializer = prepareKeySerializer(keySerializer, context,
this.name());
- valSerializer = prepareValueSerializer(valSerializer, context,
this.name());
+ try {
+ keySerializer = prepareKeySerializer(keySerializer, context,
this.name());
+ } catch (final ConfigException e) {
+ throw new ConfigException(String.format("Failed to initialize key
serdes for sink node %s", name()));
+ } catch (final StreamsException e) {
Review Comment:
Good point -- I agree with Bruno, the catch block should be for just
ConfigException or StreamsException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
