dajac commented on code in PR #16088:
URL: https://github.com/apache/kafka/pull/16088#discussion_r1622312275
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##########
@@ -66,21 +66,19 @@ public GroupAssignment assign(
GroupSpec groupSpec,
SubscribedTopicDescriber subscribedTopicDescriber
) throws PartitionAssignorException {
- AbstractUniformAssignmentBuilder assignmentBuilder;
-
if (groupSpec.members().isEmpty())
return new GroupAssignment(Collections.emptyMap());
if (groupSpec.subscriptionType().equals(HOMOGENEOUS)) {
LOG.debug("Detected that all members are subscribed to the same
set of topics, invoking the "
+ "optimized assignment algorithm");
- assignmentBuilder = new
OptimizedUniformAssignmentBuilder(groupSpec, subscribedTopicDescriber);
+ return new OptimizedUniformAssignmentBuilder(groupSpec,
subscribedTopicDescriber)
+ .build();
Review Comment:
I thought that `assignment` was redundant as this is an assignment builder.
I will also rename the general one but I will do it in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
