chia7712 commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1622375588
##########
gradle.properties:
##########
@@ -28,6 +28,8 @@ scalaVersion=2.13.14
# Adding swaggerVersion in gradle.properties to have a single version in place
for swagger
# New version of Swagger 2.2.14 requires minimum JDK 11.
swaggerVersion=2.2.8
+# 6.14.0 and newer are need for java 11
+spotlessVersion=6.13.0
Review Comment:
`spotlessVersion` is used by only one-line, hence we can inline it.
##########
README.md:
##########
@@ -232,6 +232,12 @@ You can run checkstyle using:
The checkstyle warnings will be found in
`reports/checkstyle/reports/main.html` and
`reports/checkstyle/reports/test.html` files in the
subproject build directories. They are also printed to the console. The build
will fail if Checkstyle fails.
+#### Spotless ####
+This plugin can review code by rules,it is disabled by default. You can enable
it by setting `build.gradle` add a module name into the `spotlessApplyModules`
variable like
+`def spotlessApplyModules = ['core']`,then you can run spotless using:
Review Comment:
`spotlessApplyModules` is a temporary limit, and we don't need to expose it.
##########
checkstyle/suppressions.xml:
##########
@@ -361,4 +361,7 @@
<suppress checks="(ClassDataAbstractionCoupling|ClassFanOutComplexity)"
files="(ReplicaFetcherThreadBenchmark).java"/>
+ <!--import order -->
+ <suppress checks="ImportOrder" files="^*$"/>
Review Comment:
Making the consistency is extra effort. Also, those changes will complicate
checkstyle files. Hence, I prefer to remove them if we do NOT use it actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
