[ 
https://issues.apache.org/jira/browse/KAFKA-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851128#comment-17851128
 ] 

Muralidhar Basani commented on KAFKA-16698:
-------------------------------------------

For ex : in this method updateIpConnectionRate, the updatedRate is 18.

We don't want to change this I suppose, as the test is to test for higher 
connection rate.

But altering the client quotas is something which I suspect and I don't see a 
timeout applied there.

We can try with the below, without increasing the generic field 
DEFAULT_MAX_WAIT_MS in TestUtils
{code:java}
alterClientQuotas(admin, request).all.get(15000, TimeUnit.MILLISECONDS){code}

> Fix flaky 
> kafka.network.DynamicConnectionQuotaTest#testDynamicIpConnectionRateQuota
> -----------------------------------------------------------------------------------
>
>                 Key: KAFKA-16698
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16698
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Chia-Ping Tsai
>            Priority: Major
>
> {code:java}
> org.opentest4j.AssertionFailedError: Timed out waiting for connection rate 
> update to propagate        at 
> app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)       
> at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:138)      at 
> app//kafka.network.DynamicConnectionQuotaTest.updateIpConnectionRate(DynamicConnectionQuotaTest.scala:279)
>    at 
> app//kafka.network.DynamicConnectionQuotaTest.testDynamicIpConnectionRateQuota(DynamicConnectionQuotaTest.scala:255)
>  at 
> java.base@21.0.2/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>  at java.base@21.0.2/java.lang.reflect.Method.invoke(Method.java:580)    at 
> app//org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:728)
>   at 
> app//org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
>    at 
> app//org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
>  at 
> app//org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)
>         at 
> app//org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)
>   at 
> app//org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestTemplateMethod(TimeoutExtension.java:94)
>        at 
> app//org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)
>         at 
> app//org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to