junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1622789214
##########
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##########
@@ -55,7 +55,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
.build()
val debugReplicaRequest = ListOffsetsRequest.Builder
- .forReplica(ApiKeys.LIST_OFFSETS.latestVersion,
ListOffsetsRequest.DEBUGGING_REPLICA_ID)
+ .forReplica(ApiKeys.LIST_OFFSETS.latestVersion(),
ListOffsetsRequest.DEBUGGING_REPLICA_ID)
Review Comment:
Why do we need to add the brackets?
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
- public static final MetadataVersion LATEST_PRODUCTION = IBP_3_7_IV4;
+ public static final MetadataVersion LATEST_PRODUCTION = IBP_3_8_IV1;
Review Comment:
@CalvinConfluent and @cmccabe : Is IBP_3_8_IV0 for KIP-966 production ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
