soarez commented on code in PR #15834:
URL: https://github.com/apache/kafka/pull/15834#discussion_r1623198189
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -1457,6 +1465,18 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
}
}
+ /**
+ * Validate some configurations for new MetadataVersion. A new
MetadataVersion can take place when
+ * a FeatureLevelRecord for "metadata.version" is read from the cluster
metadata.
+ */
+ def validateWithMetadataVersion(metadataVersion: MetadataVersion): Unit = {
Review Comment:
We can call this from `validateValues`, but then I won't be able to take
your other suggestion to mention `inter.broker.protocol.version` in the error
message. This one gets called when the KRaft broker discovers a new
metadata.version via a new feature record. Would you prefer we consolidate the
checks, or keep mention of `inter.broker.protocol.version` when it makes sense?
I lean towards leaving them both, so it's helpful for the operator, and the
duplication cost should go away in 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
