ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623639224


##########
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##########
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry implements 
ChannelMetadataRegistry {
 
     @Override
     public void registerCipherInformation(final CipherInformation 
cipherInformation) {
-        if (this.cipherInformation != null) {
-            this.cipherInformation = cipherInformation;
+        if (cipherInformation == null) {
+            throw new IllegalArgumentException("cipherInformation cannot be 
null");

Review Comment:
   Since there are no invocation of the above method, no tests have failed in 
local



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to