chia7712 commented on PR #16172: URL: https://github.com/apache/kafka/pull/16172#issuecomment-2145167748
It seems we are facing Trolley problem :( 1. we use spotless 6.13 in order to **support JDK 8** 2. the google-format version used by spotless 6.13 **has issue in JDK 21** (https://github.com/diffplug/spotless/pull/1920) --- Given that we are going to get rid of JDK 8 and there is example of ignoring JDK8 https://github.com/apache/kafka/blob/trunk/build.gradle#L2448 Maybe we can remove the support of JDK8 from spotless! 1. upgrade spotless to newest version 2. add `JavaVersion.current().isJava11Compatible()` check to apply spotless only if the env is JDK11+ @gongxuanzhang WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
