cmccabe commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1625003607
##########
core/src/main/scala/kafka/raft/RaftManager.scala:
##########
@@ -318,4 +329,28 @@ class KafkaRaftManager[T](
override def voterNode(id: Int, listener: String): Option[Node] = {
client.voterNode(id, listener).toScala
}
+
+ def verifyCommonFields(
+ providedClusterId: String,
+ ): Unit = {
+ if (!providedClusterId.equals(clusterId)) {
+ throw new InconsistentClusterIdException("Provided cluster ID " +
providedClusterId +
Review Comment:
> If we throw here, this will get caught here and print an error message,
right?
https://github.com/apache/kafka/pull/16058/files#diff-91060c918c99d25342f625c146f14425716eda9d8fcfe1126b2c45feff388362R152-R154
Hmm, your URL doesn't work for me. As a general matter, exceptions not
otherwise handled in ControllerApis.scala will just invoke
`AbstractRequest.getErrorResponse`.
> How about for now we just complete the requests with the unsupported
version error responses?
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
