showuon commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1625465435
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
isCancelled(), isLeader());
return;
}
+
+ copyQuotaManagerLock.lock();
+ try {
+ while (rlmCopyQuotaManager.isQuotaExceeded()) {
Review Comment:
Good point! [KAFKA-16887](https://issues.apache.org/jira/browse/KAFKA-16887)
is created for this issue.
I'm also thinking, maybe we could still skip this copy when quota exceeds,
and waiting for next RLMTask run. And if it's throttled, we can schedule
another task in 1 second delay. That will mitigate the issue @kamalcph
mentioned above, also get the same result. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
