kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626327558
##########
core/src/test/scala/integration/kafka/api/PlaintextConsumerPollTest.scala:
##########
@@ -238,6 +238,20 @@ class PlaintextConsumerPollTest extends
AbstractConsumerTest {
runMultiConsumerSessionTimeoutTest(true)
}
+ // Ensure TestUtils polls with ZERO. This fails for the new consumer only.
Review Comment:
I updated the code to allow us to pass in a duration of 0, and it doesn't
work for `CONSUMER` _or_ `CLASSIC` 🤔
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -469,7 +474,7 @@ private Throwable commitAsyncExceptionForError(Throwable
error) {
* Enqueue a request to fetch committed offsets, that will be sent on the
next call to {@link #poll(long)}.
*
* @param partitions Partitions to fetch offsets for.
- * @param deadlineMs Time until which the request should be retried
if it fails
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
