philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1627478606
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -292,7 +292,8 @@ private void closeInternal(final Duration timeout) {
/**
* Check the unsent queue one last time and poll until all requests are
sent or the timer runs out.
*/
- private void sendUnsentRequests(final Timer timer) {
+ // Visible for testing
+ protected void sendUnsentRequests(final Timer timer) {
Review Comment:
i was wondering if we could just test cleanup()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
