lianetm commented on PR #15961: URL: https://github.com/apache/kafka/pull/15961#issuecomment-2150487736
Oh I totally understand you now with that other PR and the feedback there. I see @philipnee initially suggested the managers approach but I believe we've come to the point after the discussion and changes on this PR where that approach looks like an overkill and it introduces a difference in behaviour with the legacy logic ([comments above](https://github.com/apache/kafka/pull/15961#issuecomment-2148155631)). If you agree @philipnee let's maybe close this PR and move back to the simpler approach of https://github.com/apache/kafka/pull/16043. @appchemist I'll start reviewing https://github.com/apache/kafka/pull/16043 right away just to gain time, we are running against the clock to make sure this makes it into the 3.8 cut next week. Sorry for the confusion, but seems like we're heading in the right direction now with the other PR and a better understanding of the drawbacks of the managers approach, good progress! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
