cadonna commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1628306229
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -960,7 +960,7 @@ void maybeReconcile() {
// best effort to commit the offsets in the case where the epoch might
have changed while
// the current reconciliation is in process. Note this is using the
rebalance timeout as
// it is the limit enforced by the broker to complete the
reconciliation process.
- commitResult =
commitRequestManager.maybeAutoCommitSyncBeforeRevocation(getExpirationTimeForTimeout(rebalanceTimeoutMs));
+ commitResult =
commitRequestManager.maybeAutoCommitSyncBeforeRevocation(getDeadlineMsForTimeout(rebalanceTimeoutMs));
Review Comment:
You can do it as a MINOR pull request, if you want, but it really is just a
renaming of that variable and of the parameter in the constructor as you
correctly stated in the ticket. Regarding your point in the ticket about there
is more to it than changing the name, I cannot completely follow. When somebody
instantiates a `MembershipManagerImpl` and passes the config
`rebalance.timeout.ms` into the constructor for parameter
`commitTimeoutDuringReconciliation` they state that they want to use the value
of config `rebalance.timeout.ms` as `commitTimeoutDuringReconciliation`. This
seems quite clear to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
