jeffkbkim commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628571546
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberSubscriptionAndAssignmentImpl.java:
##########
@@ -83,9 +85,10 @@ public int hashCode() {
@Override
public String toString() {
- return "MemberSubscriptionSpecImpl(rackId=" + rackId.orElse("N/A") +
+ return "MemberSubscriptionAndAssignmentImpl(rackId=" +
rackId.orElse("N/A") +
", subscribedTopicIds=" + subscribedTopicIds +
", memberAssignment=" + memberAssignment +
')';
}
+
Review Comment:
nit: i think we can remove this
##########
group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/GroupSpec.java:
##########
@@ -45,18 +45,18 @@ public interface GroupSpec {
/**
* Gets the member subscription specification for a member.
*
- * @param memberId The member Id.
+ * @param memberId The member Id.
* @return The member's subscription metadata.
* @throws IllegalArgumentException If the member Id isn't found.
*/
- MemberSubscriptionSpec memberSubscription(String memberId);
+ MemberSubscription memberSubscription(String memberId);
/**
* Gets the current assignment of the member.
*
- * @param memberId The member Id.
- * @return A map of topic Ids to sets of partition numbers.
- * An empty map is returned if the member Id isn't found.
+ * @param memberId The member Id.
+ * @return The member's assignment or an empty assignment if the
+ * member does not have one.
Review Comment:
nit: i think keeping the indentation the same looks cleaner
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java:
##########
@@ -29,7 +30,7 @@
/**
* An immutable assignment for a member.
*/
-public class Assignment {
+public class Assignment implements MemberAssignment {
Review Comment:
could you help me understand the difference between Assignment and
MemberAssignmentImpl?
Also, the name seems a bit vague given that it implements MemberAssignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
