junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1630381323
##########
metadata/src/test/java/org/apache/kafka/metadata/PartitionRegistrationTest.java:
##########
@@ -371,7 +371,7 @@ public void
testPartitionRegistrationToRecord_ElrShouldBeNullIfEmpty() {
setPartitionEpoch(0);
List<UnwritableMetadataException> exceptions = new ArrayList<>();
ImageWriterOptions options = new ImageWriterOptions.Builder().
- setMetadataVersion(MetadataVersion.IBP_3_8_IV0).
+ setMetadataVersion(MetadataVersion.IBP_3_8_IV1).
Review Comment:
Hmm, this is testing ELR. So it seems that it needs to be IBP_4_0_IV0.
@CalvinConfluent : Could you confirm this?
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -394,7 +394,7 @@ public void testUncleanShutdownBroker() throws Throwable {
new BrokerRegistrationRequestData().
setBrokerId(brokerId).
setClusterId(active.clusterId()).
-
setFeatures(brokerFeatures(MetadataVersion.IBP_3_0_IV1,
MetadataVersion.IBP_3_8_IV0)).
+
setFeatures(brokerFeatures(MetadataVersion.IBP_3_0_IV1,
MetadataVersion.IBP_3_8_IV1)).
Review Comment:
Hmm, this is testing ELR. So it seems that it needs to be IBP_4_0_IV0. Ditto
below. @CalvinConfluent : Could you confirm this?
##########
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##########
@@ -23,8 +23,8 @@ public enum TestFeatureVersion implements FeatureVersion {
// TEST_1 released right before MV 3.7-IVO was released, and it has no
dependencies
TEST_1(1, MetadataVersion.IBP_3_7_IV0, Collections.emptyMap()),
- // TEST_2 released right before MV 3.8-IVO was released, and it depends on
this metadata version
- TEST_2(2, MetadataVersion.IBP_3_8_IV0,
Collections.singletonMap(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_3_8_IV0.featureLevel()));
+ // TEST_2 released right before MV 4.0-IVO was released, and it depends on
this metadata version
Review Comment:
4.0-IVO => 4.0-IV0 This is an existing issue. The trailing number should be
0, not an O.
Ditto for 3.7-IVO above.
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
- public static final MetadataVersion LATEST_PRODUCTION = IBP_3_7_IV4;
+ public static final MetadataVersion LATEST_PRODUCTION = IBP_3_8_IV1;
Review Comment:
@jolshan : Just to clarify. Are you saying that ELR can just use MV 4.0 IV0,
instead of creating a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
