appchemist commented on code in PR #16043:
URL: https://github.com/apache/kafka/pull/16043#discussion_r1630477551


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -145,6 +154,7 @@ void runOnce() {
                 .map(networkClientDelegate::addAll)
                 .reduce(MAX_POLL_TIMEOUT_MS, Math::min);
         networkClientDelegate.poll(pollWaitTimeMs, currentTimeMs);
+        maybePropagateMetadataError();

Review Comment:
   @lianetm
   I got it.
   I will work on `NetworkClientDelegate.poll`
   
   > Any reason to have this here instead of inside the `NetworkClientDelegate` 
poll?
   
   With this work, I also wanted to address the following review points.
   https://github.com/apache/kafka/pull/16043#issuecomment-2130547360
   https://github.com/apache/kafka/pull/16043#issuecomment-2127634542



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to