kamalcph commented on code in PR #16132:
URL: https://github.com/apache/kafka/pull/16132#discussion_r1630618629
##########
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##########
@@ -402,6 +403,22 @@ class LogConfigTest {
}
}
+ @ParameterizedTest
+ @ValueSource(strings = Array("retain", "delete"))
+ def testValidRemoteLogRetentionPolicy(policy: String): Unit = {
Review Comment:
please update the test name
(eg) testValidRemoteLogDisablePolicy (or) something on similar lines
##########
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##########
@@ -402,6 +403,22 @@ class LogConfigTest {
}
}
+ @ParameterizedTest
+ @ValueSource(strings = Array("retain", "delete"))
+ def testValidRemoteLogRetentionPolicy(policy: String): Unit = {
+ val logProps = new Properties
+ logProps.put(TopicConfig.REMOTE_LOG_DISABLE_POLICY_CONFIG, policy)
+ LogConfig.validate(logProps)
+ }
+
+ @ParameterizedTest
+ @ValueSource(strings = Array("keep", "remove"))
+ def testInvalidRemoteLogRetentionPolicy(policy: String): Unit = {
Review Comment:
please update the test name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
