philipnee commented on code in PR #16043: URL: https://github.com/apache/kafka/pull/16043#discussion_r1631394278
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ########## @@ -360,6 +367,18 @@ void testSendUnsentRequest() { assertFalse(networkClient.hasAnyPendingRequests()); } + @Test + void testMetadataErrorEvent() { Review Comment: for this test we are essentially testing if networkClientDelegate is enqueue an error event to the background event queue, so i don't think we need this test here since you've written tests in network client delegate and integration test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org