chia7712 commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632120413
##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -353,6 +354,9 @@ static private void setupNodeDirectories(File baseDirectory,
private final TestKitNodes nodes;
private final Map<Integer, ControllerServer> controllers;
private final Map<Integer, BrokerServer> brokers;
+
+ private final Map<Integer, Boolean> aliveBrokers;
Review Comment:
Instead of tracing alive brokers, maybe we should add a new method
`isShutdown` to `KafkaBroker`?
##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {
controllerNode.metadataDirectory());
}
props.put(SocketServerConfigs.LISTENER_SECURITY_PROTOCOL_MAP_CONFIG,
- "EXTERNAL:PLAINTEXT,CONTROLLER:PLAINTEXT");
+
"EXTERNAL:PLAINTEXT,CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT");
Review Comment:
why we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
