OmniaGM commented on code in PR #16116: URL: https://github.com/apache/kafka/pull/16116#discussion_r1632977311
########## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ########## @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.config; + +import org.apache.kafka.common.compress.GzipCompression; +import org.apache.kafka.common.compress.Lz4Compression; +import org.apache.kafka.common.compress.ZstdCompression; +import org.apache.kafka.common.config.ConfigDef; +import org.apache.kafka.common.config.SaslConfigs; +import org.apache.kafka.common.config.SecurityConfig; +import org.apache.kafka.common.config.SslClientAuth; +import org.apache.kafka.common.config.SslConfigs; +import org.apache.kafka.common.config.TopicConfig; +import org.apache.kafka.common.config.internals.BrokerSecurityConfigs; +import org.apache.kafka.common.record.LegacyRecord; +import org.apache.kafka.common.record.Records; +import org.apache.kafka.common.security.auth.SecurityProtocol; +import org.apache.kafka.common.utils.Utils; +import org.apache.kafka.coordinator.group.ConsumerGroupMigrationPolicy; +import org.apache.kafka.coordinator.group.Group; +import org.apache.kafka.coordinator.group.GroupCoordinatorConfig; +import org.apache.kafka.coordinator.transaction.TransactionLogConfigs; +import org.apache.kafka.coordinator.transaction.TransactionStateManagerConfigs; +import org.apache.kafka.network.SocketServerConfigs; +import org.apache.kafka.raft.QuorumConfig; +import org.apache.kafka.security.PasswordEncoderConfigs; +import org.apache.kafka.server.common.MetadataVersionValidator; +import org.apache.kafka.server.metrics.MetricConfigs; +import org.apache.kafka.server.record.BrokerCompressionType; +import org.apache.kafka.storage.internals.log.CleanerConfig; +import org.apache.kafka.storage.internals.log.LogConfig; + +import java.util.Collections; +import java.util.concurrent.TimeUnit; + +import static org.apache.kafka.common.config.ConfigDef.Importance.HIGH; +import static org.apache.kafka.common.config.ConfigDef.Importance.LOW; +import static org.apache.kafka.common.config.ConfigDef.Importance.MEDIUM; +import static org.apache.kafka.common.config.ConfigDef.Range.atLeast; +import static org.apache.kafka.common.config.ConfigDef.Range.between; +import static org.apache.kafka.common.config.ConfigDef.Type.BOOLEAN; +import static org.apache.kafka.common.config.ConfigDef.Type.CLASS; +import static org.apache.kafka.common.config.ConfigDef.Type.DOUBLE; +import static org.apache.kafka.common.config.ConfigDef.Type.INT; +import static org.apache.kafka.common.config.ConfigDef.Type.LIST; +import static org.apache.kafka.common.config.ConfigDef.Type.LONG; +import static org.apache.kafka.common.config.ConfigDef.Type.PASSWORD; +import static org.apache.kafka.common.config.ConfigDef.Type.SHORT; +import static org.apache.kafka.common.config.ConfigDef.Type.STRING; + +public class KafkaConfig { Review Comment: I was planning to keep 2 KafkaConfig for the time being while moving everything out of core. Using `KafkaConfigDef` has the following **Pros:** - The ConfigDef is huge so having this out of `KafkaConfig` whether it is the original `KafkaConfig` in `core` or the new `KafkaConfig` in `server`. **Cons:** - We will have class that only contains 1 static variable and most likely not going to scale for any thing else. Having 2 `KafkaConfig` (most likely the one in core will keep getting smaller and smaller till we are ready to delete). The idea I have is the one in `server` will be an abstract class that will be extended by the one in `core` and I slowly will move stuff out of `core::KafkaConfig` to `server::KafkaConfig` **Pros:** - easier to review as all references and imports will point to KafkaConfig in core during the process of moving the getters into `server`. And the last PR will be just changing the import to the right `KafkaConfig` - Removing ZK code from `core::KafkaConfig` (which will happened in the next few weeks) will not create conflicts in `server::KafkaConfig` as I can ignore moving ZK `getters` and validation. **Cons:** - We have two `KafkaConfig` for a period of time I don't mind renaming this to `KafkaConfigDef` but my point is going forward we most likely going to have 2 `KafkaConfig` for a short period of time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
