cadonna commented on code in PR #16241: URL: https://github.com/apache/kafka/pull/16241#discussion_r1633243629
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ########## @@ -514,10 +514,11 @@ private void fetchOffsetsWithRetries(final OffsetFetchRequestState fetchRequest, // Retry the same fetch request while it fails with RetriableException and the retry timeout hasn't expired. currentResult.whenComplete((res, error) -> { - boolean inflightRemoved = pendingRequests.inflightOffsetFetches.remove(fetchRequest); - if (!inflightRemoved) { - log.warn("A duplicated, inflight, request was identified, but unable to find it in the " + - "outbound buffer:" + fetchRequest); + if (!fetchRequest.isExpired()) { + boolean inflightRemoved = pendingRequests.inflightOffsetFetches.remove(fetchRequest); + if (!inflightRemoved) { + log.warn("The response for the offset fetch request for partitions {} was not found in the inflight buffer", fetchRequest.requestedPartitions); + } Review Comment: When is the request removed from the `inflightOffsetFetches` expired? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org