cmccabe commented on code in PR #16284:
URL: https://github.com/apache/kafka/pull/16284#discussion_r1635402983
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##########
@@ -109,7 +111,8 @@ public PartitionChangeBuilder(
int partitionId,
IntPredicate isAcceptableLeader,
MetadataVersion metadataVersion,
- int minISR
+ int minISR,
+ Optional<QuorumControllerMetrics> metrics
Review Comment:
The metrics for unclean leader elections should be in
ControllerMetadataMetrics, not here. See below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
