brandboat opened a new pull request, #16305:
URL: https://github.com/apache/kafka/pull/16305

   related to https://issues.apache.org/jira/browse/KAFKA-16942
   
   per discussed in 
https://github.com/apache/kafka/pull/16231#discussion_r1635345881
   
   Through the ConcurrentMapBenchmark, we observed that in scenarios where 
write operations (i.e., computeIfAbsent) constitute 10%, the get performance of 
CopyOnWriteMap is lower compared to ConcurrentHashMap. However, when iterating 
over entrySet and values, CopyOnWriteMap performs better than ConcurrentHashMap.
   
   In RecordAccumulator#nodeStats, the computeIfAbsent method is rarely 
triggered, and we only use the get method to read data. Therefore, switching to 
ConcurrentHashMap would gain better performance.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to