philipnee commented on code in PR #16272:
URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1512,7 +1513,9 @@ public void unsubscribe() {
}
resetGroupMetadata();
}
- subscriptions.unsubscribe();
+ } catch (Exception e) {
+ log.error("Unsubscribe failed", e);
+ throw e;
Review Comment:
for InterruptedException, I wonder if we should call Thread.Interrupted() so
that the user can have a chance to cleanly shutdown the consumer. wdyt?
Also InterruptedException can be thrown everywhere now, i guess the reason
we are seeing this during shutdown is for the obvious reason, the worker calls
unsubscribe before shutting down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
