chia7712 commented on code in PR #16345:
URL: https://github.com/apache/kafka/pull/16345#discussion_r1641765619
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -680,6 +694,7 @@ public NetworkClientDelegate.UnsentRequest
toUnsentRequest() {
}
if (memberInfo.memberEpoch.isPresent()) {
data =
data.setGenerationIdOrMemberEpoch(memberInfo.memberEpoch.get());
+ lastEpochSentOnCommit =
Optional.of(memberInfo.memberEpoch.get());
Review Comment:
It seems we can assign `memberInfo.memberEpoch` to `lastEpochSentOnCommit`
as `Optional` is a POJO
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -680,6 +694,7 @@ public NetworkClientDelegate.UnsentRequest
toUnsentRequest() {
}
if (memberInfo.memberEpoch.isPresent()) {
data =
data.setGenerationIdOrMemberEpoch(memberInfo.memberEpoch.get());
+ lastEpochSentOnCommit =
Optional.of(memberInfo.memberEpoch.get());
Review Comment:
For another, should we reset `lastEpochSentOnCommit` to none if
`memberInfo.memberEpoch` is not defined?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -741,6 +756,9 @@ public void onResponse(final ClientResponse response) {
"failed with unknown member ID. " +
error.message()));
return;
} else if (error == Errors.STALE_MEMBER_EPOCH) {
+ log.error("OffsetCommit failed for member {} with
stale member epoch error. Last epoch sent: {}",
+ memberInfo.memberId.orElse("undefined"),
+ lastEpochSentOnCommit.isPresent() ?
lastEpochSentOnCommit.get() : "None");
Review Comment:
maybe we can replace "None" by "undefined" for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
