lemessdavi opened a new pull request, #16365:
URL: https://github.com/apache/kafka/pull/16365

   According to the PMD code smell analysis "LooseCoupling" and 
"ControlStatementBraces"
   
   Excessive coupling to implementation types (e.g., HashSet) limits your 
ability to use alternate implementations in the future as requirements change. 
Whenever available, declare variables and parameters using a more general type 
(e.g, Set).
   
   Enforce a policy for braces on control statements. It is recommended to use 
braces on ‘if … else’ statements and loop statements, even if they are 
optional. This usually makes the code clearer, and helps prepare the future 
when you need to add another statement. That said, this rule lets you control 
which statements are required to have braces via properties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to