rajinisivaram commented on code in PR #16329:
URL: https://github.com/apache/kafka/pull/16329#discussion_r1642299815
##########
core/src/main/scala/kafka/network/RequestChannel.scala:
##########
@@ -262,7 +262,9 @@ object RequestChannel extends Logging {
m.responseSendTimeHist.update(Math.round(responseSendTimeMs))
m.totalTimeHist.update(Math.round(totalTimeMs))
m.requestBytesHist.update(sizeOfBodyInBytes)
-
m.messageConversionsTimeHist.foreach(_.update(Math.round(messageConversionsTimeMs)))
+ if (messageConversionsTimeMs > 0) {
Review Comment:
It will be better to check `messageConversionsTimeNanos` instead of the
converted `ms`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
