rajinisivaram commented on code in PR #16346: URL: https://github.com/apache/kafka/pull/16346#discussion_r1642352229
########## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ########## @@ -640,8 +640,8 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Logging reconfigurable.validateReconfiguration(newConfigs) } catch { case e: ConfigException => throw e - case _: Exception => - throw new ConfigException(s"Validation of dynamic config update of $updatedConfigNames failed with class ${reconfigurable.getClass}") + case e: Exception => + throw new ConfigException(s"Validation of dynamic config update of $updatedConfigNames failed with class ${reconfigurable.getClass} due to: $e") Review Comment: Some config exceptions may contain sensitive data like SASL passwords or SSL info. We need to make sure the exception string doesn't include any sensitive information, especially if it could be sent to clients. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org