dajac commented on code in PR #16347:
URL: https://github.com/apache/kafka/pull/16347#discussion_r1642442783
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -202,11 +202,12 @@ public enum MetadataVersion {
// Add new fetch request version for KIP-951
IBP_3_7_IV4(19, "3.7", "IV4", false),
- // Add ELR related supports (KIP-966).
- IBP_3_8_IV0(20, "3.8", "IV0", true),
+ // New version for the Kafka 3.8.0 release.
+ IBP_3_8_IV0(20, "3.8", "IV0", false),
+ // Add ELR related supports (KIP-966).
Review Comment:
I wonder if we should put a comment here explaining that the MV below this
point are not production ready. We could also add a few words explaining that
features must be reviewed and they must moved to the next one if they are not
ready when the next MV is made production ready.
##########
server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java:
##########
@@ -22,7 +22,7 @@
public enum GroupVersion implements FeatureVersion {
// Version 1 enables the consumer rebalance protocol (KIP-848).
- GV_1(1, MetadataVersion.IBP_4_0_IV0, Collections.emptyMap());
+ GV_1(1, MetadataVersion.IBP_3_9_IV0, Collections.emptyMap());
Review Comment:
Should we keep it attached to `IBP_4_0_IV0` as we already know that it will
be release in 4.0? If not, we should file a blocker for 3.9 to ensure that we
change it before we release 3.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
