C0urante commented on PR #16332: URL: https://github.com/apache/kafka/pull/16332#issuecomment-2173591962
@aliehsaeedii I like this approach a lot more than the pluggable error handler interface! But it seems like there's risk to this change. Allowing transactions to commit where they would previously have failed may break existing applications, especially if `flush` is invoked on a different thread than the one that calls `commitTransaction`. If the flush/commit API were relatively new I think this would be acceptable, but given that they've been around for several years, I think we should be cautious. IMO this warrants a KIP, and should possibly only be released in a new major version (which, luckily for us all, is right around the corner with 4.0.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
