jolshan commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1643566934
##########
clients/src/test/java/org/apache/kafka/common/requests/ProduceRequestTest.java:
##########
@@ -120,15 +121,38 @@ public void testBuildWithCurrentMessageFormat() {
ProduceRequest.Builder requestBuilder =
ProduceRequest.forMagic(RecordBatch.CURRENT_MAGIC_VALUE,
new ProduceRequestData()
.setTopicData(new
ProduceRequestData.TopicProduceDataCollection(Collections.singletonList(
- new
ProduceRequestData.TopicProduceData().setName("test").setPartitionData(Collections.singletonList(
- new
ProduceRequestData.PartitionProduceData().setIndex(9).setRecords(builder.build()))))
+ new
ProduceRequestData.TopicProduceData()
+ .setName("test")
Review Comment:
will we have a case we write both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
