mimaison commented on code in PR #16375:
URL: https://github.com/apache/kafka/pull/16375#discussion_r1644600311
##########
docs/streams/developer-guide/app-reset-tool.html:
##########
@@ -78,9 +78,9 @@
<h2>Step 1: Run the application reset tool<a class="headerlink"
href="#step-1-run-the-application-reset-tool" title="Permalink to this
headline"></a></h2>
<p>Invoke the application reset tool from the command line</p>
<p>Warning! This tool makes irreversible changes to your
application. It is strongly recommended that you run this once with <code
class="docutils literal"><span class="pre">--dry-run</span></code> to preview
your changes before making them.</p>
- <pre class="line-numbers"><code
class="language-bash"><path-to-kafka>/bin/kafka-streams-application-reset</code></pre>
+ <pre<code class="language-bash">$
bin/kafka-streams-application-reset</code></pre>
Review Comment:
Fixed
##########
docs/implementation.html:
##########
@@ -75,13 +75,13 @@ <h4 class="anchor-heading"><a id="recordbatch"
class="anchor-link"></a><a href="
<h5 class="anchor-heading"><a id="controlbatch" class="anchor-link"></a><a
href="#controlbatch">5.3.1.1 Control Batches</a></h5>
<p>A control batch contains a single record called the control record.
Control records should not be passed on to applications. Instead, they are used
by consumers to filter out aborted transactional messages.</p>
<p> The key of a control record conforms to the following schema: </p>
- <pre class="line-numbers"><code class="language-text">version: int16
(current version is 0)
+ <pre><code class="language-text">version: int16 (current version is 0)
type: int16 (0 indicates an abort marker, 1 indicates a commit)</code></pre>
<p>The schema for the value of a control record is dependent on the type.
The value is opaque to clients.</p>
<h4 class="anchor-heading"><a id="record" class="anchor-link"></a><a
href="#record">5.3.2 Record</a></h4>
<p>Record level headers were introduced in Kafka 0.11.0. The on-disk
format of a record with Headers is delineated below. </p>
- <pre class="line-numbers"><code class="language-text">length: varint
+ <pre"><code class="language-text">length: varint
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
