gharris1727 commented on code in PR #16324:
URL: https://github.com/apache/kafka/pull/16324#discussion_r1644671854


##########
build.gradle:
##########
@@ -928,14 +928,15 @@ project(':server') {
     implementation libs.jacksonDatabind
 
     implementation libs.slf4jApi
+    implementation libs.slf4jReload4j

Review Comment:
   > "should we guarantee the compatibility of dependency chain in updating 
kafka dependencies?"
   
   I think where the dependency becomes part of our API surface (i.e. we expect 
a normal user to bring in additional jars affected by it) we should (and have) 
taken more care with compatibility.
   
   For another example, this is a KIP dependency upgrade, because that 
dependency forms part of our API: 
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1032%3A+Upgrade+to+Jakarta+and+JavaEE+9+in+Kafka+4.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to